Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Add VARBINARY column to switch case branch #9313

Merged
merged 1 commit into from Sep 1, 2022

Conversation

walterddr
Copy link
Contributor

@walterddr walterddr commented Aug 31, 2022

calcite considered bytes as VARBINARY. so adding the case branch to the switch

@walterddr walterddr marked this pull request as ready for review August 31, 2022 21:56
@walterddr walterddr changed the title adding a varbinary column for testing Add varbinary column switch case branch Aug 31, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9313 (3c5a56f) into master (1c9528c) will decrease coverage by 44.90%.
The diff coverage is n/a.

❗ Current head 3c5a56f differs from pull request most recent head 0f3fa16. Consider uploading reports for the commit 0f3fa16 to get more accurate results

@@              Coverage Diff              @@
##             master    #9313       +/-   ##
=============================================
- Coverage     69.73%   24.83%   -44.91%     
+ Complexity     5017       53     -4964     
=============================================
  Files          1873     1861       -12     
  Lines         99598    99245      -353     
  Branches      15163    15125       -38     
=============================================
- Hits          69453    24644    -44809     
- Misses        25217    72116    +46899     
+ Partials       4928     2485     -2443     
Flag Coverage Δ
integration1 ?
integration2 24.83% <ø> (+0.03%) ⬆️
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...not/query/planner/logical/RelToStageConverter.java 0.00% <ø> (-73.92%) ⬇️
...in/java/org/apache/pinot/spi/utils/BytesUtils.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/BaseRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/NoOpRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/user/RoleType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/utils/NullValueUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1363 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walterddr walterddr changed the title Add varbinary column switch case branch [hotfix] Add VARBINARY column to switch case branch Sep 1, 2022
@walterddr walterddr merged commit 22de7d2 into apache:master Sep 1, 2022
@walterddr walterddr deleted the pr_hotfix_schema_converter branch December 6, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants