Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade h3 lib from 3.7.2 to 4.0.0 to lower glibc requirement #9335

Merged
merged 1 commit into from Sep 4, 2022

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Sep 4, 2022

This PR fixes the issue of higher glibc requirements to prevent centos 7 or ubuntu 18 to not able to run pinot.
See discussion here: uber/h3-java#85

@xiangfu0
Copy link
Contributor Author

xiangfu0 commented Sep 4, 2022

cc: @KKcorps can you help verify this on Mac M1 laptop ?

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2022

Codecov Report

Merging #9335 (879add1) into master (b4c8271) will increase coverage by 41.55%.
The diff coverage is 60.00%.

@@              Coverage Diff              @@
##             master    #9335       +/-   ##
=============================================
+ Coverage     28.21%   69.76%   +41.55%     
- Complexity       53     4700     +4647     
=============================================
  Files          1863     1875       +12     
  Lines         99507    99860      +353     
  Branches      15156    15194       +38     
=============================================
+ Hits          28073    69670    +41597     
+ Misses        68688    25267    -43421     
- Partials       2746     4923     +2177     
Flag Coverage Δ
integration1 26.23% <0.00%> (+0.19%) ⬆️
integration2 24.77% <0.00%> (+0.17%) ⬆️
unittests1 67.08% <60.00%> (?)
unittests2 15.25% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../org/apache/pinot/segment/local/utils/H3Utils.java 40.38% <60.00%> (+40.38%) ⬆️
...tream/kafka20/server/KafkaDataServerStartable.java 72.91% <0.00%> (-6.25%) ⬇️
...nMaxValueBasedSelectionOrderByCombineOperator.java 72.51% <0.00%> (-0.77%) ⬇️
...che/pinot/broker/routing/BrokerRoutingManager.java 85.31% <0.00%> (-0.57%) ⬇️
...ache/pinot/common/metadata/ZKMetadataProvider.java 66.85% <0.00%> (-0.57%) ⬇️
...pache/pinot/core/query/utils/idset/EmptyIdSet.java 25.00% <0.00%> (ø)
...anager/realtime/SegmentBuildTimeLeaseExtender.java 63.23% <0.00%> (ø)
...not/ingestion/common/DefaultControllerRestApi.java 0.00% <0.00%> (ø)
...apache/pinot/ingestion/jobs/SegmentTarPushJob.java 70.27% <0.00%> (ø)
.../pinot/ingestion/jobs/SegmentPreprocessingJob.java 0.00% <0.00%> (ø)
... and 1290 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KKcorps
Copy link
Contributor

KKcorps commented Sep 4, 2022

Started RealtimeQuickstart and tested geoToS3 query function and it works perfectly without any issues on M1.

@xiangfu0 xiangfu0 merged commit 0f4bcfc into apache:master Sep 4, 2022
@xiangfu0 xiangfu0 deleted the fixing_h3_lib branch September 4, 2022 13:12
@xiangfu0
Copy link
Contributor Author

xiangfu0 commented Sep 4, 2022

Thanks @KKcorps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants