Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thread safety issues with SDF (WIP) #9425

Merged
merged 1 commit into from Sep 19, 2022

Conversation

saurabhd336
Copy link
Contributor

@saurabhd336 saurabhd336 commented Sep 19, 2022

SimpleDateFormat is not thread safe. Moving to DateTimeFormatter wherever SDF's instances were being shared b/w threads

@saurabhd336 saurabhd336 changed the title Fix thread safety issues with SDF Fix thread safety issues with SDF (WIP) Sep 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #9425 (8f25c3a) into master (2d6665b) will increase coverage by 0.03%.
The diff coverage is 90.00%.

@@             Coverage Diff              @@
##             master    #9425      +/-   ##
============================================
+ Coverage     69.73%   69.77%   +0.03%     
+ Complexity     4787     4710      -77     
============================================
  Files          1890     1890              
  Lines        100756   100755       -1     
  Branches      15350    15350              
============================================
+ Hits          70266    70300      +34     
+ Misses        25507    25456      -51     
- Partials       4983     4999      +16     
Flag Coverage Δ
integration1 26.03% <20.00%> (+<0.01%) ⬆️
integration2 24.69% <20.00%> (-0.01%) ⬇️
unittests1 66.99% <100.00%> (-0.02%) ⬇️
unittests2 15.38% <20.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntroller/helix/core/PinotHelixResourceManager.java 71.69% <66.66%> (-0.12%) ⬇️
...a/org/apache/pinot/common/utils/DateTimeUtils.java 100.00% <100.00%> (ø)
...rg/apache/pinot/spi/utils/GroovyTemplateUtils.java 86.95% <100.00%> (ø)
...ntroller/helix/core/minion/TaskMetricsEmitter.java 34.88% <0.00%> (-51.17%) ⬇️
...he/pinot/segment/local/segment/store/IndexKey.java 65.00% <0.00%> (-15.00%) ⬇️
...ore/query/scheduler/resources/ResourceManager.java 84.00% <0.00%> (-12.00%) ⬇️
...or/transform/function/IsNullTransformFunction.java 78.57% <0.00%> (-7.15%) ⬇️
...tream/kafka20/server/KafkaDataServerStartable.java 72.91% <0.00%> (-6.25%) ⬇️
.../pinot/core/query/scheduler/PriorityScheduler.java 77.77% <0.00%> (-5.56%) ⬇️
...lter/predicate/NotInPredicateEvaluatorFactory.java 78.35% <0.00%> (-4.48%) ⬇️
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Jackie-Jiang Jackie-Jiang merged commit 353774f into apache:master Sep 19, 2022
61yao pushed a commit to 61yao/pinot that referenced this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants