Fix Data-Correctness Bug in GTE Comparison in BinaryOperatorTransformFunction #9461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitsultana
commented
Sep 24, 2022
.../java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java
Show resolved
Hide resolved
Jackie-Jiang
approved these changes
Sep 26, 2022
jackjlli
approved these changes
Sep 26, 2022
|
Added a UT. Existing tests weren't able to catch this case since this only happens when the argument types are:
I also found a bug in my PR. I had only updated calls for one of the |
Codecov Report
@@ Coverage Diff @@
## master #9461 +/- ##
============================================
- Coverage 69.88% 69.83% -0.05%
- Complexity 5127 5134 +7
============================================
Files 1909 1910 +1
Lines 101749 101769 +20
Branches 15440 15444 +4
============================================
- Hits 71104 71071 -33
- Misses 25627 25677 +50
- Partials 5018 5021 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
61yao
pushed a commit
to 61yao/pinot
that referenced
this pull request
Oct 3, 2022
…Function (apache#9461) * Fix Bug in Handling GTE Comparison in BinaryOperatorTransformFunction * Add UT * Fix bug and add another test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9460
The BinaryOperatorTransformFunction::compare methods already call
getIntResult, but the places where it's called callsgetIntResultagain.https://github.com/apache/pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BinaryOperatorTransformFunction.java#L371
Say the comparison is: 10 >= 20
Then, the call chain is (bottom-up): Double.compare(10, 20) ==> -1 ==> getIntResult(-1) ==> 0 ==> getIntResult(0) ==> 1
Which means 10 >= 20 gets evaluated to true
cc: @yupeng9 @chenboat