New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get task runtime configs tracked in Helix #9540
get task runtime configs tracked in Helix #9540
Conversation
...c/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java
Show resolved
Hide resolved
...roller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #9540 +/- ##
============================================
- Coverage 69.86% 63.69% -6.17%
- Complexity 4795 4848 +53
============================================
Files 1927 1874 -53
Lines 102697 100401 -2296
Branches 15586 15317 -269
============================================
- Hits 71747 63951 -7796
- Misses 25878 31741 +5863
+ Partials 5072 4709 -363
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
Added a restful API to get task runtime configs like concurrencyPerWorker and taskTimeout. Note that those are not inside the subtasks' configs. Also refine some logs found useful when debugging minion related APIs.
Release Note
/tasks/task/{taskName}/runtime/config: a new restful API added on controller to get task runtime configs like subtask concurrency per worker and task timeout