Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: fix incorrect task finish time #9557

Merged
merged 1 commit into from Oct 12, 2022
Merged

UI: fix incorrect task finish time #9557

merged 1 commit into from Oct 12, 2022

Conversation

jayeshchoudhary
Copy link
Contributor

@jayeshchoudhary jayeshchoudhary commented Oct 7, 2022 •
edited

What does this PR do?

  • Fix incorrect task finish time display in UI

Description

  • Earlier when fetching task details(via task debug API) there was no task level finishTime available.
  • For the workaround UI displayed the first subtask finishTime subTaskInfos[0].finishTime, which is incorrect considering each task can have multiple subTasks with different finishTime.
  • With the recent changes in this PR expose task finish time via debug API #9534, task debug API now exposes task level finishTime, which the UI can consume to fix the issue.

Reviewers - @klsince @npawar @joshigaurava

@xiangfu0 xiangfu0 merged commit 00d35a2 into apache:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangfu0 xiangfu0 xiangfu0 approved these changes

@klsince klsince klsince approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jayeshchoudhary @xiangfu0 @klsince