Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove more unused filter code #9620

Merged
merged 1 commit into from Oct 18, 2022
Merged

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Oct 18, 2022

cc @Jackie-Jiang as a follow up to more unused files that can be cleaned up from #9607

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Merging #9620 (7fba076) into master (63c6438) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9620      +/-   ##
============================================
- Coverage     68.71%   68.69%   -0.02%     
+ Complexity     4971     4897      -74     
============================================
  Files          1939     1937       -2     
  Lines        103671   103666       -5     
  Branches      15727    15728       +1     
============================================
- Hits          71242    71218      -24     
- Misses        27350    27370      +20     
+ Partials       5079     5078       -1     
Flag Coverage Δ
integration1 25.83% <ø> (+0.04%) ⬆️
unittests1 67.39% <ø> (+0.02%) ⬆️
unittests2 15.59% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...data/manager/realtime/DefaultSegmentCommitter.java 0.00% <0.00%> (-80.00%) ⬇️
...a/org/apache/pinot/core/operator/BaseOperator.java 60.00% <0.00%> (-40.00%) ⬇️
...er/api/resources/LLCSegmentCompletionHandlers.java 43.56% <0.00%> (-18.82%) ⬇️
...ache/pinot/core/operator/docidsets/OrDocIdSet.java 86.36% <0.00%> (-13.64%) ⬇️
...data/manager/realtime/SegmentCommitterFactory.java 70.58% <0.00%> (-11.77%) ⬇️
...altime/ServerSegmentCompletionProtocolHandler.java 51.88% <0.00%> (-6.61%) ⬇️
.../predicate/NotEqualsPredicateEvaluatorFactory.java 68.75% <0.00%> (-5.36%) ⬇️
.../filter/predicate/InPredicateEvaluatorFactory.java 69.92% <0.00%> (-4.52%) ⬇️
.../pinot/query/runtime/blocks/TransferableBlock.java 69.56% <0.00%> (-4.35%) ⬇️
...core/operator/docvalsets/TransformBlockValSet.java 59.43% <0.00%> (-2.84%) ⬇️
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walterddr walterddr merged commit e715969 into apache:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants