Fix string split which should be on whole separator #9650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
added
release-notes
Codecov Report
@@ Coverage Diff @@
## master #9650 +/- ##
============================================
+ Coverage 62.83% 62.86% +0.02%
+ Complexity 5162 5161 -1
============================================
Files 1935 1935
Lines 103815 103815
Branches 15758 15758
============================================
+ Hits 65236 65259 +23
+ Misses 33708 33680 -28
- Partials 4871 4876 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
snleee
approved these changes
Oct 25, 2022
| } | ||
|
|
||
| /** | ||
| * TODO: Revisit if index should be zero-based |
There was a problem hiding this comment.
What do you mean by zero-based here? Can you elaborate the concern here?
There was a problem hiding this comment.
See the discussion under #9554. Added more comments to make it more clear
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
split()andsplit_part()scalar function which should be split on whole separator. Currentlysplit(col, 'ab')will split on bothaandbwhich is incorrect.