Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert default timeout nano change in QueryConfig #9790

Merged
merged 2 commits into from Nov 14, 2022

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Nov 14, 2022

this was accidentally checked in as part of debugging and should be reverted (see https://github.com/apache/pinot/pull/9711/files#diff-432313d724e736eb977d1ba6dd06db03340ff9e75440004e343dda8c4121024b)

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #9790 (db52967) into master (8c9af20) will increase coverage by 4.55%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9790      +/-   ##
============================================
+ Coverage     64.02%   68.58%   +4.55%     
- Complexity     4953     4987      +34     
============================================
  Files          1902     1956      +54     
  Lines        102463   104975    +2512     
  Branches      15587    15892     +305     
============================================
+ Hits          65607    71998    +6391     
+ Misses        32088    27867    -4221     
- Partials       4768     5110     +342     
Flag Coverage Δ
integration1 25.24% <ø> (?)
unittests1 67.77% <ø> (+0.13%) ⬆️
unittests2 15.68% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/apache/pinot/query/runtime/QueryRunner.java 74.33% <0.00%> (-7.22%) ⬇️
...rg/apache/pinot/common/datablock/RowDataBlock.java 62.50% <0.00%> (-4.17%) ⬇️
...g/apache/pinot/common/datablock/BaseDataBlock.java 75.31% <0.00%> (-2.13%) ⬇️
...e/pinot/segment/local/io/util/PinotDataBitSet.java 95.62% <0.00%> (-1.46%) ⬇️
...loader/defaultcolumn/BaseDefaultColumnHandler.java 57.49% <0.00%> (-0.74%) ⬇️
.../pinot/core/data/manager/BaseTableDataManager.java 75.44% <0.00%> (-0.39%) ⬇️
...t/query/runtime/blocks/TransferableBlockUtils.java 91.17% <0.00%> (-0.13%) ⬇️
.../assignment/segment/RealtimeSegmentAssignment.java 92.47% <0.00%> (-0.09%) ⬇️
.../pinot/core/common/datablock/DataBlockBuilder.java 72.98% <0.00%> (ø)
.../aggregation/function/ModeAggregationFunction.java 86.75% <0.00%> (ø)
... and 394 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@walterddr walterddr merged commit 463c120 into apache:master Nov 14, 2022
@agavra agavra deleted the revert_typo branch November 14, 2022 18:14
@walterddr walterddr added the multi-stage Related to the multi-stage query engine label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants