Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to update and delete table config via CLI #9852

Merged
merged 4 commits into from Dec 7, 2022

Conversation

KKcorps
Copy link
Contributor

@KKcorps KKcorps commented Nov 23, 2022

Addresses #9840

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #9852 (7357bf4) into master (2dae951) will increase coverage by 1.48%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9852      +/-   ##
============================================
+ Coverage     68.96%   70.44%   +1.48%     
+ Complexity     5522     5058     -464     
============================================
  Files          1978     1982       +4     
  Lines        106182   106449     +267     
  Branches      16089    16131      +42     
============================================
+ Hits          73230    74991    +1761     
+ Misses        27820    26220    -1600     
- Partials       5132     5238     +106     
Flag Coverage Δ
integration1 24.99% <ø> (?)
integration2 24.38% <ø> (-0.13%) ⬇️
unittests1 67.95% <ø> (+0.04%) ⬆️
unittests2 15.82% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...or/transform/function/IsNullTransformFunction.java 79.31% <0.00%> (-6.90%) ⬇️
...accounting/CPUMemThreadLevelAccountingObjects.java 82.75% <0.00%> (-6.90%) ⬇️
...uery/runtime/executor/OpChainSchedulerService.java 88.37% <0.00%> (-6.75%) ⬇️
...not/query/planner/logical/RelToStageConverter.java 80.59% <0.00%> (-6.45%) ⬇️
...ache/pinot/query/mailbox/GrpcReceivingMailbox.java 87.50% <0.00%> (-5.61%) ⬇️
.../filter/predicate/InPredicateEvaluatorFactory.java 74.43% <0.00%> (-4.52%) ⬇️
...in/stream/kafka20/KafkaPartitionLevelConsumer.java 66.66% <0.00%> (-3.34%) ⬇️
...lix/core/realtime/PinotRealtimeSegmentManager.java 75.39% <0.00%> (-3.15%) ⬇️
.../mailbox/channel/MailboxContentStreamObserver.java 70.00% <0.00%> (-2.73%) ⬇️
...va/org/apache/pinot/query/service/QueryServer.java 73.17% <0.00%> (-2.39%) ⬇️
... and 188 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@KKcorps KKcorps changed the title Add capability top update and delete table config via CLI Add capability to update and delete table config via CLI Nov 25, 2022
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, using ModifyTable to create table is not very intuitive. I'd suggest adding a -update flag in the current AddTableCommand, and add a separate DeleteTableCommand for the table deletion which only takes the table name without config

@Jackie-Jiang
Copy link
Contributor

#9857 Added the command for table/schema deletion, so let's just add the update flag in this PR

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KKcorps KKcorps merged commit bb83f5c into apache:master Dec 7, 2022
@KKcorps KKcorps deleted the update_table_patch branch December 7, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants