New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to update and delete table config via CLI #9852
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9852 +/- ##
============================================
+ Coverage 68.96% 70.44% +1.48%
+ Complexity 5522 5058 -464
============================================
Files 1978 1982 +4
Lines 106182 106449 +267
Branches 16089 16131 +42
============================================
+ Hits 73230 74991 +1761
+ Misses 27820 26220 -1600
- Partials 5132 5238 +106
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, using ModifyTable
to create table is not very intuitive. I'd suggest adding a -update
flag in the current AddTableCommand
, and add a separate DeleteTableCommand
for the table deletion which only takes the table name without config
#9857 Added the command for table/schema deletion, so let's just add the update flag in this PR |
08e8f3b
to
f29c6ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addresses #9840