Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bloom filter creation on BYTES #9898

Merged
merged 1 commit into from Dec 2, 2022

Conversation

Jackie-Jiang
Copy link
Contributor

This is a quick fix for the BYTES support. There are other issues related to bloom filter, and I will create an issue around it and use a separate PR for more fixes and testing.

Copy link
Contributor

@klsince klsince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jackie-Jiang
Copy link
Contributor Author

Created #9899 to track other issues

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Merging #9898 (b86a498) into master (716797f) will increase coverage by 43.73%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #9898       +/-   ##
=============================================
+ Coverage     24.94%   68.68%   +43.73%     
- Complexity       44     5050     +5006     
=============================================
  Files          1966     1978       +12     
  Lines        105835   106193      +358     
  Branches      16056    16097       +41     
=============================================
+ Hits          26404    72937    +46533     
+ Misses        76743    28109    -48634     
- Partials       2688     5147     +2459     
Flag Coverage Δ
integration1 25.14% <0.00%> (+0.19%) ⬆️
unittests1 67.91% <0.00%> (?)
unittests2 15.80% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ment/creator/impl/SegmentColumnarIndexCreator.java 80.26% <0.00%> (+80.26%) ⬆️
...ache/pinot/core/operator/docidsets/OrDocIdSet.java 86.36% <0.00%> (-13.64%) ⬇️
...core/startree/operator/StarTreeFilterOperator.java 85.43% <0.00%> (-1.99%) ⬇️
...pache/pinot/core/query/utils/idset/EmptyIdSet.java 25.00% <0.00%> (ø)
...inot/core/util/SegmentCompletionProtocolUtils.java 57.69% <0.00%> (ø)
...anager/realtime/SegmentBuildTimeLeaseExtender.java 63.23% <0.00%> (ø)
...ker/api/resources/BrokerEchoWithAutoDiscovery.java 0.00% <0.00%> (ø)
...pache/pinot/ingestion/jobs/SegmentCreationJob.java 0.00% <0.00%> (ø)
.../pinot/ingestion/jobs/SegmentPreprocessingJob.java 0.00% <0.00%> (ø)
...rg/apache/pinot/ingestion/jobs/BaseSegmentJob.java 31.57% <0.00%> (ø)
... and 1380 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@npawar npawar merged commit 568d858 into apache:master Dec 2, 2022
@Jackie-Jiang Jackie-Jiang deleted the fix_bloom_filter_bytes branch December 2, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants