Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to initialize S3PinotFs with serverSideEncryption properties when passing client directly #9988

Merged
merged 2 commits into from Dec 14, 2022

Conversation

npawar
Copy link
Contributor

@npawar npawar commented Dec 14, 2022

When using init method below, we cannot initialize serverSideEncryption properties.

public void init(S3Client s3Client) {
    _s3Client = s3Client;
  }

Adding a new init method, which takes server side encryption props along with the S3Client.

@npawar npawar added the bugfix label Dec 14, 2022
Copy link
Contributor

@klsince klsince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Merging #9988 (7fc7f69) into master (f743ff1) will increase coverage by 0.09%.
The diff coverage is 9.09%.

@@             Coverage Diff              @@
##             master    #9988      +/-   ##
============================================
+ Coverage     70.34%   70.44%   +0.09%     
- Complexity     5656     5657       +1     
============================================
  Files          1989     1989              
  Lines        107181   107185       +4     
  Branches      16290    16289       -1     
============================================
+ Hits          75400    75503     +103     
+ Misses        26515    26414     -101     
- Partials       5266     5268       +2     
Flag Coverage Δ
integration1 25.06% <0.00%> (-0.05%) ⬇️
integration2 24.52% <0.00%> (+0.15%) ⬆️
unittests1 67.87% <ø> (-0.01%) ⬇️
unittests2 13.61% <9.09%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../org/apache/pinot/plugin/filesystem/S3PinotFS.java 41.33% <9.09%> (-0.56%) ⬇️
.../common/request/context/predicate/EqPredicate.java 92.30% <0.00%> (-7.70%) ⬇️
...mmon/request/context/predicate/NotEqPredicate.java 76.92% <0.00%> (-7.70%) ⬇️
...n/java/org/apache/pinot/common/utils/URIUtils.java 66.66% <0.00%> (-7.41%) ⬇️
...elix/core/periodictask/ControllerPeriodicTask.java 66.07% <0.00%> (-5.36%) ⬇️
.../filter/predicate/InPredicateEvaluatorFactory.java 74.43% <0.00%> (-4.52%) ⬇️
...er/starter/helix/SegmentMessageHandlerFactory.java 61.79% <0.00%> (-3.38%) ⬇️
...server/starter/helix/HelixInstanceDataManager.java 70.58% <0.00%> (-3.37%) ⬇️
...gregation/function/StUnionAggregationFunction.java 73.52% <0.00%> (-2.95%) ⬇️
...inot/core/operator/filter/FilterOperatorUtils.java 87.50% <0.00%> (-2.50%) ⬇️
... and 33 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@npawar npawar merged commit 2d0cbc1 into apache:master Dec 14, 2022
@npawar npawar deleted the s3_pinot_fs branch December 14, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants