refactor(plc4go): convert some panics to errors

apache · May 10, 2023 · 1eaa3d5 · 1eaa3d5
1 parent 3011a3e
commit 1eaa3d5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/plc4go/internal/cbus/MessageCodec.go b/plc4go/internal/cbus/MessageCodec.go
@@ -234,7 +234,7 @@ lookingForTheEnd:
 
 	// Sanity check
 	if pciResponse && requestToPci {
-		panic("Invalid state... Can not be response and request at the same time")
+		return nil, errors.New("Invalid state... Can not be response and request at the same time")
 	}
 
 	// We need to ensure that there is no ! till the first /r
@@ -271,7 +271,7 @@ lookingForTheEnd:
 		log.Trace().Msgf("Read packet length %d", packetLength)
 		read, err := ti.Read(uint32(packetLength))
 		if err != nil {
-			panic("Invalid state... If we have peeked that before we should be able to read that now")
+			return nil, errors.Wrap(err, "Invalid state... If we have peeked that before we should be able to read that now")
 		}
 		rawInput = read
 	}

diff --git a/plc4go/spi/transports/pcap/Transport.go b/plc4go/spi/transports/pcap/Transport.go
@@ -142,7 +142,8 @@ func (m *TransportInstance) Connect() error {
 					break
 				}
 				log.Warn().Err(err).Msg("Error reading")
-				panic(err)
+				m.connected = false
+				return
 			}
 			if lastPacketTime != nil && m.speedFactor != 0 {
 				timeToSleep := captureInfo.Timestamp.Sub(*lastPacketTime)