refactor(codegen/plc4go): reworked enum parsing to include a flag if …

…it is a unknown enum

code-generation/language-go/src/main/resources/templates/go/enum-template.go.ftlh

@@ -126,28 +126,24 @@ func ${type.name}FirstEnumForField${constantName?cap_first}(value ${helper.getLa
 }
 	</#list>
 </#if>
-func ${type.name}ByValue(value <#if type.type.isPresent()>${helper.getLanguageTypeNameForTypeReference(type.type.orElseThrow())}<#else>string</#if>) ${type.name} {
+func ${type.name}ByValue(value <#if type.type.isPresent()>${helper.getLanguageTypeNameForTypeReference(type.type.orElseThrow())}<#else>string</#if>) (enum ${type.name}, ok bool) {
 	switch value {
 <#list helper.getUniqueEnumValues(type.enumValues) as enumValue>
 		case <#if type.type.orElseThrow().isStringTypeReference()>"${enumValue.value}"<#else>${enumValue.value}</#if>:
-			return ${type.name}_${enumValue.name}
+			return ${type.name}_${enumValue.name}, true
 </#list>
 	}
-	return <#if type.type.orElseThrow().isStringTypeReference()>""<#elseif baseType == "bool">false<#else>0</#if>
+	return <#if type.type.orElseThrow().isStringTypeReference()>""<#elseif baseType == "bool">false<#else>0</#if>, false
 }
 
 func ${type.name}ByName(value string) (enum ${type.name}, ok bool) {
-	ok = true
 	switch value {
 	<#list helper.getUniqueEnumValues(type.enumValues) as enumValue>
 	case "${enumValue.name}":
-		enum = ${type.name}_${enumValue.name}
+		return ${type.name}_${enumValue.name}, true
 	</#list>
-	default:
-		enum = <#if type.type.orElseThrow().isStringTypeReference()>""<#elseif baseType == "bool">false<#else>0</#if>
-		ok = false
 	}
-	return
+	return <#if type.type.orElseThrow().isStringTypeReference()>""<#elseif baseType == "bool">false<#else>0</#if>, false
 }
 
 func ${type.name}Knows(value <#if type.type.isPresent()>${helper.getLanguageTypeNameForTypeReference(type.type.orElseThrow())}<#else>string</#if>)  bool {
@@ -186,7 +182,11 @@ func ${type.name}Parse(readBuffer utils.ReadBuffer) (${type.name}, error) {
 	if err != nil {
 		return <#if type.type.orElseThrow().isStringTypeReference() || type.type.orElseThrow().isVstringTypeReference()>""<#elseif baseType == "bool">false<#else>0</#if>, errors.Wrap(err, "error reading ${type.name}")
 	}
-	return ${type.name}ByValue(val), nil
+	if enum, ok := ${type.name}ByValue(val); !ok {
+		return <#if type.type.orElseThrow().isStringTypeReference() || type.type.orElseThrow().isVstringTypeReference()>""<#elseif baseType == "bool">false<#else>0</#if>, errors.Errorf("no value %v found for ${type.name}", val)
+	} else {
+		return enum, nil
+	}
 }
 
 func (e ${type.name}) Serialize(writeBuffer utils.WriteBuffer) error {

plc4go/internal/ads/Reader.go

@@ -396,12 +396,13 @@ func (m *Reader) ToPlc4xReadResponse(amsTcpPaket readWriteModel.AmsTCPPacket, re
 				responseCodes[fieldName] = model.PlcResponseCode_INTERNAL_ERROR
 				continue
 			}
-			switch readWriteModel.ReturnCodeByValue(responseCode) {
+			val, _ := readWriteModel.ReturnCodeByValue(responseCode)
+			switch val {
 			case readWriteModel.ReturnCode_OK:
 				responseCodes[fieldName] = model.PlcResponseCode_OK
 			default:
 				// TODO: Implement this a little more ...
-				log.Error().Stringer("adsReturnCode", readWriteModel.ReturnCodeByValue(responseCode)).Msgf("Unmapped return code for %s", fieldName)
+				log.Error().Stringer("adsReturnCode", val).Msgf("Unmapped return code for %s", fieldName)
 				responseCodes[fieldName] = model.PlcResponseCode_INTERNAL_ERROR
 			}
 		}

plc4go/internal/s7/TsapIdEncoder.go

@@ -29,7 +29,8 @@ func encodeS7TsapId(deviceGroup model.DeviceGroup, rack int32, slot int32) uint1
 
 func decodeDeviceGroup(tsapId int32) model.DeviceGroup {
 	deviceGroupCode := uint8((tsapId >> 8) & (0xFF))
-	return model.DeviceGroupByValue(deviceGroupCode)
+	value, _ := model.DeviceGroupByValue(deviceGroupCode)
+	return value
 }
 
 func decodeRack(tsapId int32) int64 {