refactor(plc4go/spi): cleanup unused types

apache · May 17, 2023 · 794183a · 794183a
1 parent 1f16e0f
commit 794183a
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 150 deletions.
diff --git a/plc4go/spi/model/DefaultPlcSubscriptionRequestResult.go b/plc4go/spi/model/DefaultPlcSubscriptionRequestResult.go
diff --git a/plc4go/spi/model/DefaultPlcSubscriptionRequestResult_plc4xgen.go b/plc4go/spi/model/DefaultPlcSubscriptionRequestResult_plc4xgen.go
diff --git a/plc4go/spi/model/DefaultPlcTagRequest.go b/plc4go/spi/model/DefaultPlcTagRequest.go
@@ -42,8 +42,9 @@ func (d *DefaultPlcTagRequest) GetTagNames() []string {
 }
 
 func (d *DefaultPlcTagRequest) GetTag(name string) apiModel.PlcTag {
-	if tag, ok := d.tags[name]; ok {
-		return tag
+	tag, ok := d.tags[name]
+	if !ok {
+		return nil
 	}
-	return nil
+	return tag
 }
diff --git a/plc4go/spi/model/DefaultPlcWriteRequest.go b/plc4go/spi/model/DefaultPlcWriteRequest.go
@@ -194,5 +194,6 @@ func (d *DefaultPlcWriteRequest) GetWriteRequestInterceptor() interceptors.Write
 }
 
 func (d *DefaultPlcWriteRequest) GetValue(name string) apiValues.PlcValue {
+	// TODO: guard
 	return d.values[name]
 }
diff --git a/plc4go/spi/model/DefaultPlcWriteResponse.go b/plc4go/spi/model/DefaultPlcWriteResponse.go
@@ -60,5 +60,6 @@ func (d *DefaultPlcWriteResponse) GetRequest() apiModel.PlcWriteRequest {
 }
 
 func (d *DefaultPlcWriteResponse) GetResponseCode(name string) apiModel.PlcResponseCode {
+	// TODO: guard
 	return d.responseCodes[name]
 }
diff --git a/plc4go/spi/model/render_test.go b/plc4go/spi/model/render_test.go
@@ -55,7 +55,6 @@ func TestRenderTest(t *testing.T) {
 		&DefaultPlcSubscriptionEventItem{},
 		&DefaultPlcSubscriptionHandle{},
 		&DefaultPlcSubscriptionRequest{DefaultPlcTagRequest: NewDefaultPlcTagRequest(nil, nil)},
-		&DefaultPlcSubscriptionRequestResult{},
 		&DefaultPlcSubscriptionResponse{},
 		&DefaultPlcSubscriptionResponseItem{},
 		&DefaultPlcTagRequest{},