fix(opcua): Add Null Variant (#1124)

apache · Oct 11, 2023 · 847fead · 847fead
1 parent 5391e37
commit 847fead
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/plc4j/drivers/opcua/src/main/generated/org/apache/plc4x/java/opcua/readwrite/Variant.java b/plc4j/drivers/opcua/src/main/generated/org/apache/plc4x/java/opcua/readwrite/Variant.java
@@ -158,7 +158,9 @@ public static Variant staticParse(ReadBuffer readBuffer) throws ParseException {
 
     // Switch Field (Depending on the discriminator values, passes the instantiation to a sub-type)
     VariantBuilder builder = null;
-    if (EvaluationHelper.equals(VariantType, (byte) 1)) {
+    if (EvaluationHelper.equals(VariantType, (byte) 0)) {
+      builder = VariantNull.staticParseVariantBuilder(readBuffer);
+    } else if (EvaluationHelper.equals(VariantType, (byte) 1)) {
       builder = VariantBoolean.staticParseVariantBuilder(readBuffer, arrayLengthSpecified);
     } else if (EvaluationHelper.equals(VariantType, (byte) 2)) {
       builder = VariantSByte.staticParseVariantBuilder(readBuffer, arrayLengthSpecified);

diff --git a/protocols/opcua/src/main/xslt/opc-manual.xsl b/protocols/opcua/src/main/xslt/opc-manual.xsl
@@ -238,6 +238,8 @@
     [simple bit arrayDimensionsSpecified]
     [discriminator uint 6 VariantType]
     [typeSwitch VariantType,arrayLengthSpecified
+        ['0' VariantNull
+        ]
         ['1' VariantBoolean (bit arrayLengthSpecified)
             [optional int 32 arrayLength 'arrayLengthSpecified']
             [array byte value count 'arrayLength == null ? 1 : arrayLength']