Skip to content

Commit

Permalink
feat(plc4go): add additional output for analyzer
Browse files Browse the repository at this point in the history
  • Loading branch information
sruehl committed Jul 5, 2022
1 parent 23ca265 commit 88f255b
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion plc4go/tools/plc4xpcapanalyzer/internal/analyzer/analyzer.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ func Analyze(pcapFile, protocolType, filter string, onlyParse, noBytesCompare bo
BarStart: "[",
BarEnd: "]",
}))
failedPackages := 0
for packet := range source.Packets() {
if packet == nil {
log.Debug().Msg("Done reading packages. (nil returned)")
Expand Down Expand Up @@ -97,6 +98,7 @@ func Analyze(pcapFile, protocolType, filter string, onlyParse, noBytesCompare bo
}
payload := applicationLayer.Payload()
if parsed, err := packageParse(packetInformation, payload); err != nil {
failedPackages++
// TODO: write report to xml or something
log.Warn().Stringer("packetInformation", packetInformation).Err(err).Msgf("No.[%d] Error parsing package", realPacketNumber)
continue
Expand All @@ -111,6 +113,7 @@ func Analyze(pcapFile, protocolType, filter string, onlyParse, noBytesCompare bo
}
serializedBytes, err := serializePackage(parsed)
if err != nil {
failedPackages++
// TODO: write report to xml or something
log.Warn().Stringer("packetInformation", packetInformation).Err(err).Msgf("No.[%d] Error serializing", realPacketNumber)
continue
Expand All @@ -120,6 +123,7 @@ func Analyze(pcapFile, protocolType, filter string, onlyParse, noBytesCompare bo
continue
}
if compareResult := bytes.Compare(payload, serializedBytes); compareResult != 0 {
failedPackages++
// TODO: write report to xml or something
log.Warn().Stringer("packetInformation", packetInformation).Msgf("No.[%d] Bytes don't match", realPacketNumber)
if verbosity > 0 {
Expand All @@ -132,5 +136,5 @@ func Analyze(pcapFile, protocolType, filter string, onlyParse, noBytesCompare bo
}
}

log.Info().Msgf("Done evaluating %d packages", numberOfPackage)
log.Info().Msgf("Done evaluating %d packages (%d failed)", numberOfPackage, failedPackages)
}

0 comments on commit 88f255b

Please sign in to comment.