refactor(plc4j): fixed some Q/A issues

code-generation/language-java/src/main/resources/templates/java/enum-template.java.ftlh

@@ -102,7 +102,7 @@ public enum ${type.name} {
 </#if>
 <#if type.constantNames?has_content>
     <#list type.constantNames as constantName>
-        private ${helper.getLanguageTypeNameForTypeReference(type.getConstantType(constantName), true)} ${constantName};
+        private final ${helper.getLanguageTypeNameForTypeReference(type.getConstantType(constantName), true)} ${constantName};
     </#list>
 </#if>
 

plc4j/drivers/ads/src/main/generated/org/apache/plc4x/java/ads/readwrite/AdsDataType.java

@@ -76,8 +76,8 @@ public enum AdsDataType {
   }
 
   private final byte value;
-  private int numBytes;
-  private PlcValueType plcValueType;
+  private final int numBytes;
+  private final PlcValueType plcValueType;
 
   AdsDataType(byte value, int numBytes, PlcValueType plcValueType) {
     this.value = value;

plc4j/drivers/bacnet/src/main/generated/org/apache/plc4x/java/bacnetip/readwrite/BACnetVendorId.java

@@ -1642,8 +1642,8 @@ public enum BACnetVendorId {
   }
 
   private final int value;
-  private int vendorId;
-  private String vendorName;
+  private final int vendorId;
+  private final String vendorName;
 
   BACnetVendorId(int value, int vendorId, String vendorName) {
     this.value = value;

plc4j/drivers/bacnet/src/main/generated/org/apache/plc4x/java/bacnetip/readwrite/MaxApduLengthAccepted.java

@@ -52,7 +52,7 @@ public enum MaxApduLengthAccepted {
   }
 
   private final byte value;
-  private int numberOfOctets;
+  private final int numberOfOctets;
 
   MaxApduLengthAccepted(byte value, int numberOfOctets) {
     this.value = value;

plc4j/drivers/bacnet/src/main/generated/org/apache/plc4x/java/bacnetip/readwrite/MaxSegmentsAccepted.java

@@ -44,7 +44,7 @@ public enum MaxSegmentsAccepted {
   }
 
   private final byte value;
-  private short maxSegments;
+  private final short maxSegments;
 
   MaxSegmentsAccepted(byte value, short maxSegments) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/AccessControlCommandType.java

@@ -44,7 +44,7 @@ public enum AccessControlCommandType {
   }
 
   private final byte value;
-  private short numberOfArguments;
+  private final short numberOfArguments;
 
   AccessControlCommandType(byte value, short numberOfArguments) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/AccessControlCommandTypeContainer.java

@@ -386,9 +386,9 @@ public enum AccessControlCommandTypeContainer {
   }
 
   private final short value;
-  private short numBytes;
-  private AccessControlCommandType commandType;
-  private AccessControlCategory category;
+  private final short numBytes;
+  private final AccessControlCommandType commandType;
+  private final AccessControlCategory category;
 
   AccessControlCommandTypeContainer(
       short value,

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/AirConditioningCommandType.java

@@ -55,7 +55,7 @@ public enum AirConditioningCommandType {
   }
 
   private final byte value;
-  private short numberOfArguments;
+  private final short numberOfArguments;
 
   AirConditioningCommandType(byte value, short numberOfArguments) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/AirConditioningCommandTypeContainer.java

@@ -73,8 +73,8 @@ public enum AirConditioningCommandTypeContainer {
   }
 
   private final short value;
-  private short numBytes;
-  private AirConditioningCommandType commandType;
+  private final short numBytes;
+  private final AirConditioningCommandType commandType;
 
   AirConditioningCommandTypeContainer(
       short value, short numBytes, AirConditioningCommandType commandType) {

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/ApplicationIdContainer.java

@@ -300,8 +300,8 @@ public enum ApplicationIdContainer {
   }
 
   private final short value;
-  private LightingCompatible lightingCompatible;
-  private ApplicationId applicationId;
+  private final LightingCompatible lightingCompatible;
+  private final ApplicationId applicationId;
 
   ApplicationIdContainer(
       short value, LightingCompatible lightingCompatible, ApplicationId applicationId) {

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/Attribute.java

@@ -54,7 +54,7 @@ public enum Attribute {
   }
 
   private final short value;
-  private short bytesReturned;
+  private final short bytesReturned;
 
   Attribute(short value, short bytesReturned) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/CALCommandTypeContainer.java

@@ -153,8 +153,8 @@ public enum CALCommandTypeContainer {
   }
 
   private final short value;
-  private short numBytes;
-  private CALCommandType commandType;
+  private final short numBytes;
+  private final CALCommandType commandType;
 
   CALCommandTypeContainer(short value, short numBytes, CALCommandType commandType) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/ClockAndTimekeepingCommandType.java

@@ -38,7 +38,7 @@ public enum ClockAndTimekeepingCommandType {
   }
 
   private final byte value;
-  private short numberOfArguments;
+  private final short numberOfArguments;
 
   ClockAndTimekeepingCommandType(byte value, short numberOfArguments) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/ClockAndTimekeepingCommandTypeContainer.java

@@ -55,8 +55,8 @@ public enum ClockAndTimekeepingCommandTypeContainer {
   }
 
   private final short value;
-  private short numBytes;
-  private ClockAndTimekeepingCommandType commandType;
+  private final short numBytes;
+  private final ClockAndTimekeepingCommandType commandType;
 
   ClockAndTimekeepingCommandTypeContainer(
       short value, short numBytes, ClockAndTimekeepingCommandType commandType) {

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/EnableControlCommandType.java

@@ -37,7 +37,7 @@ public enum EnableControlCommandType {
   }
 
   private final byte value;
-  private short numberOfArguments;
+  private final short numberOfArguments;
 
   EnableControlCommandType(byte value, short numberOfArguments) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/EnableControlCommandTypeContainer.java

@@ -68,8 +68,8 @@ public enum EnableControlCommandTypeContainer {
   }
 
   private final short value;
-  private short numBytes;
-  private EnableControlCommandType commandType;
+  private final short numBytes;
+  private final EnableControlCommandType commandType;
 
   EnableControlCommandTypeContainer(
       short value, short numBytes, EnableControlCommandType commandType) {

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/ErrorReportingCommandType.java

@@ -40,7 +40,7 @@ public enum ErrorReportingCommandType {
   }
 
   private final byte value;
-  private short numberOfArguments;
+  private final short numberOfArguments;
 
   ErrorReportingCommandType(byte value, short numberOfArguments) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/ErrorReportingCommandTypeContainer.java

@@ -41,8 +41,8 @@ public enum ErrorReportingCommandTypeContainer {
   }
 
   private final short value;
-  private short numBytes;
-  private ErrorReportingCommandType commandType;
+  private final short numBytes;
+  private final ErrorReportingCommandType commandType;
 
   ErrorReportingCommandTypeContainer(
       short value, short numBytes, ErrorReportingCommandType commandType) {

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/LevelInformationNibblePair.java

@@ -52,7 +52,7 @@ public enum LevelInformationNibblePair {
   }
 
   private final short value;
-  private byte nibbleValue;
+  private final byte nibbleValue;
 
   LevelInformationNibblePair(short value, byte nibbleValue) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/LightingCommandType.java

@@ -41,7 +41,7 @@ public enum LightingCommandType {
   }
 
   private final byte value;
-  private short numberOfArguments;
+  private final short numberOfArguments;
 
   LightingCommandType(byte value, short numberOfArguments) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/LightingCommandTypeContainer.java

@@ -88,8 +88,8 @@ public enum LightingCommandTypeContainer {
   }
 
   private final short value;
-  private short numBytes;
-  private LightingCommandType commandType;
+  private final short numBytes;
+  private final LightingCommandType commandType;
 
   LightingCommandTypeContainer(short value, short numBytes, LightingCommandType commandType) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/MeasurementCommandType.java

@@ -37,7 +37,7 @@ public enum MeasurementCommandType {
   }
 
   private final byte value;
-  private short numberOfArguments;
+  private final short numberOfArguments;
 
   MeasurementCommandType(byte value, short numberOfArguments) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/MeasurementCommandTypeContainer.java

@@ -38,8 +38,8 @@ public enum MeasurementCommandTypeContainer {
   }
 
   private final short value;
-  private short numBytes;
-  private MeasurementCommandType commandType;
+  private final short numBytes;
+  private final MeasurementCommandType commandType;
 
   MeasurementCommandTypeContainer(short value, short numBytes, MeasurementCommandType commandType) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/MediaTransportControlCommandType.java

@@ -57,7 +57,7 @@ public enum MediaTransportControlCommandType {
   }
 
   private final byte value;
-  private short numberOfArguments;
+  private final short numberOfArguments;
 
   MediaTransportControlCommandType(byte value, short numberOfArguments) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/MediaTransportControlCommandTypeContainer.java

@@ -265,8 +265,8 @@ public enum MediaTransportControlCommandTypeContainer {
   }
 
   private final short value;
-  private short numBytes;
-  private MediaTransportControlCommandType commandType;
+  private final short numBytes;
+  private final MediaTransportControlCommandType commandType;
 
   MediaTransportControlCommandTypeContainer(
       short value, short numBytes, MediaTransportControlCommandType commandType) {

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/MeteringCommandType.java

@@ -37,7 +37,7 @@ public enum MeteringCommandType {
   }
 
   private final byte value;
-  private short numberOfArguments;
+  private final short numberOfArguments;
 
   MeteringCommandType(byte value, short numberOfArguments) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/MeteringCommandTypeContainer.java

@@ -44,8 +44,8 @@ public enum MeteringCommandTypeContainer {
   }
 
   private final short value;
-  private short numBytes;
-  private MeteringCommandType commandType;
+  private final short numBytes;
+  private final MeteringCommandType commandType;
 
   MeteringCommandTypeContainer(short value, short numBytes, MeteringCommandType commandType) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/Parameter.java

@@ -2084,12 +2084,12 @@ public enum Parameter {
   }
 
   private final short value;
-  private ParameterType parameterType;
-  private String form;
-  private boolean isVolatile;
-  private String parameterDescription;
-  private ProtectionLevel protectionLevel;
-  private String group;
+  private final ParameterType parameterType;
+  private final String form;
+  private final boolean isVolatile;
+  private final String parameterDescription;
+  private final ProtectionLevel protectionLevel;
+  private final String group;
 
   Parameter(
       short value,

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/ProtectionLevel.java

@@ -40,7 +40,7 @@ public enum ProtectionLevel {
   }
 
   private final byte value;
-  private String description;
+  private final String description;
 
   ProtectionLevel(byte value, String description) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/RequestType.java

@@ -43,7 +43,7 @@ public enum RequestType {
   }
 
   private final short value;
-  private short controlChar;
+  private final short controlChar;
 
   RequestType(short value, short controlChar) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/SecurityCommandType.java

@@ -39,7 +39,7 @@ public enum SecurityCommandType {
   }
 
   private final byte value;
-  private short numberOfArguments;
+  private final short numberOfArguments;
 
   SecurityCommandType(byte value, short numberOfArguments) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/SecurityCommandTypeContainer.java

@@ -156,8 +156,8 @@ public enum SecurityCommandTypeContainer {
   }
 
   private final short value;
-  private short numBytes;
-  private SecurityCommandType commandType;
+  private final short numBytes;
+  private final SecurityCommandType commandType;
 
   SecurityCommandTypeContainer(short value, short numBytes, SecurityCommandType commandType) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/TelephonyCommandType.java

@@ -37,7 +37,7 @@ public enum TelephonyCommandType {
   }
 
   private final byte value;
-  private short numberOfArguments;
+  private final short numberOfArguments;
 
   TelephonyCommandType(byte value, short numberOfArguments) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/TelephonyCommandTypeContainer.java

@@ -69,8 +69,8 @@ public enum TelephonyCommandTypeContainer {
   }
 
   private final short value;
-  private short numBytes;
-  private TelephonyCommandType commandType;
+  private final short numBytes;
+  private final TelephonyCommandType commandType;
 
   TelephonyCommandTypeContainer(short value, short numBytes, TelephonyCommandType commandType) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/TemperatureBroadcastCommandType.java

@@ -37,7 +37,7 @@ public enum TemperatureBroadcastCommandType {
   }
 
   private final byte value;
-  private short numberOfArguments;
+  private final short numberOfArguments;
 
   TemperatureBroadcastCommandType(byte value, short numberOfArguments) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/TemperatureBroadcastCommandTypeContainer.java

@@ -69,8 +69,8 @@ public enum TemperatureBroadcastCommandTypeContainer {
   }
 
   private final short value;
-  private short numBytes;
-  private TemperatureBroadcastCommandType commandType;
+  private final short numBytes;
+  private final TemperatureBroadcastCommandType commandType;
 
   TemperatureBroadcastCommandTypeContainer(
       short value, short numBytes, TemperatureBroadcastCommandType commandType) {

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/TriggerControlCommandType.java

@@ -41,7 +41,7 @@ public enum TriggerControlCommandType {
   }
 
   private final byte value;
-  private short numberOfArguments;
+  private final short numberOfArguments;
 
   TriggerControlCommandType(byte value, short numberOfArguments) {
     this.value = value;

plc4j/drivers/c-bus/src/main/generated/org/apache/plc4x/java/cbus/readwrite/TriggerControlCommandTypeContainer.java

@@ -106,8 +106,8 @@ public enum TriggerControlCommandTypeContainer {
   }
 
   private final short value;
-  private short numBytes;
-  private TriggerControlCommandType commandType;
+  private final short numBytes;
+  private final TriggerControlCommandType commandType;
 
   TriggerControlCommandTypeContainer(
       short value, short numBytes, TriggerControlCommandType commandType) {

plc4j/drivers/can/src/main/generated/org/apache/plc4x/java/genericcan/readwrite/GenericCANDataType.java

@@ -56,8 +56,8 @@ public enum GenericCANDataType {
   }
 
   private final long value;
-  private String plcValueName;
-  private short numBits;
+  private final String plcValueName;
+  private final short numBits;
 
   GenericCANDataType(long value, String plcValueName, short numBits) {
     this.value = value;