Skip to content

Commit

Permalink
fix(plc4py): Replace builtin types (list and dict) with class from th…
Browse files Browse the repository at this point in the history
…e typing package.
  • Loading branch information
hutcheb committed Nov 14, 2022
1 parent 135452d commit dd9d36f
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions sandbox/plc4py/plc4py/PlcDriverManager.py
Expand Up @@ -20,7 +20,7 @@
import logging
from contextlib import asynccontextmanager
from dataclasses import dataclass, field
from typing import Type, AsyncIterator, List
from typing import Type, AsyncIterator, List, Dict
from pluggy import PluginManager # type: ignore

from plc4py.api.PlcConnection import PlcConnection
Expand All @@ -32,7 +32,7 @@
@dataclass
class PlcDriverManager:
class_loader: PluginManager = field(default_factory=lambda: PluginManager("plc4py"))
_driverMap: dict[str, Type[PlcDriver]] = field(default_factory=lambda: {})
_driverMap: Dict[str, Type[PlcDriver]] = field(default_factory=lambda: {})

def __post_init__(self):
logging.info(
Expand Down
4 changes: 2 additions & 2 deletions sandbox/plc4py/plc4py/drivers/mock/MockConnection.py
Expand Up @@ -20,7 +20,7 @@
import asyncio
import logging
from dataclasses import dataclass, field
from typing import Awaitable, Type, List
from typing import Awaitable, Type, List, Dict

import plc4py

Expand Down Expand Up @@ -73,7 +73,7 @@ def of(fieldquery: str) -> MockPlcField:

@dataclass
class MockDevice:
fields: dict[str, PlcValue] = field(default_factory=lambda: {})
fields: Dict[str, PlcValue] = field(default_factory=lambda: {})

def read(self, field: str) -> List[ResponseItem[PlcValue]]:
"""
Expand Down
4 changes: 2 additions & 2 deletions sandbox/plc4py/plc4py/spi/configuration/PlcConfiguration.py
Expand Up @@ -18,7 +18,7 @@
#
import re
from dataclasses import InitVar, dataclass, field
from typing import Optional
from typing import Optional, Dict


@dataclass
Expand All @@ -28,7 +28,7 @@ class PlcConfiguration:
transport: Optional[str] = None
host: Optional[str] = None
port: Optional[int] = None
parameters: dict[str, str] = field(default_factory=lambda: {})
parameters: Dict[str, str] = field(default_factory=lambda: {})

def __post_init__(self, url):
self._parse_configuration(url)
Expand Down
6 changes: 3 additions & 3 deletions sandbox/plc4py/plc4py/spi/connection/ProtocolStack.py
Expand Up @@ -18,7 +18,7 @@
#
from abc import ABC, abstractmethod
from dataclasses import dataclass
from typing import TypeVar, Generic, Callable, Any
from typing import TypeVar, Generic, Callable, Any, List

from plc4py.api.listener import EventListener
from plc4py.spi.Plc4xBaseProtocol import Plc4xBaseProtocol
Expand Down Expand Up @@ -49,7 +49,7 @@ def configure_pipeline(
configuration: Configuration,
pipeline: ChannelPipeline,
passive: bool = False,
listeners: list[EventListener] = [],
listeners: List[EventListener] = [],
) -> Plc4xBaseProtocol:
pass

Expand All @@ -71,6 +71,6 @@ def configure_pipeline(
configuration: Configuration,
pipeline: ChannelPipeline,
passive: bool = False,
listeners: list[EventListener] = [],
listeners: List[EventListener] = [],
) -> Plc4xBaseProtocol:
pass

0 comments on commit dd9d36f

Please sign in to comment.