Skip to content

Commit

Permalink
fix(codegen/plc4go): fixed issue when multiple wildcards are used
Browse files Browse the repository at this point in the history
Golang doesn't like multiple true && true therefore we compare the index
  • Loading branch information
sruehl committed Jul 6, 2022
1 parent df6aef1 commit e282643
Show file tree
Hide file tree
Showing 11 changed files with 465 additions and 464 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1354,7 +1354,8 @@ func ${type.name}Parse(readBuffer utils.ReadBuffer<#if hasParserArguments>, ${pa
case
<#list case.discriminatorValueTerms as discriminatorValueTerm>
<#if helper.isWildcard(discriminatorValueTerm)>
true
// TODO: we could use the above isWildcard as filter but then the switchField.discriminatorExpressions[discriminatorValueTerm?index] is offset. Solution would be to have it as a pair list
${discriminatorValueTerm?index}==${discriminatorValueTerm?index}
<#else>
<#assign discriminatorExpression=switchField.discriminatorExpressions[discriminatorValueTerm?index]>
<#assign parsedDiscriminatorExpression=helper.toParseExpression(null, null, discriminatorExpression, parserArguments)>
Expand Down
2 changes: 1 addition & 1 deletion plc4go/protocols/bacnetip/readwrite/model/APDU.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

908 changes: 454 additions & 454 deletions plc4go/protocols/bacnetip/readwrite/model/BACnetConstructedData.go

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion plc4go/protocols/bacnetip/readwrite/model/BACnetError.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e282643

Please sign in to comment.