feat(cbus): implemented ventilation application

apache · Jul 18, 2022 · f8dbf89 · f8dbf89
1 parent 0119d0a
commit f8dbf89
Show file tree

Hide file tree

Showing 3 changed files with 56 additions and 7 deletions.
diff --git a/plc4go/protocols/cbus/readwrite/model/SALDataVentilation.go b/plc4go/protocols/cbus/readwrite/model/SALDataVentilation.go
diff --git a/plc4j/drivers/c-bus/src/test/java/org/apache/plc4x/java/cbus/ReferenceTest.java b/plc4j/drivers/c-bus/src/test/java/org/apache/plc4x/java/cbus/ReferenceTest.java
@@ -1024,4 +1024,10 @@ void temperatureBroadcast() throws Exception {
             }
         }
     }
+
+    // from: https://updates.clipsal.com/ClipsalSoftwareDownload/DL/downloads/OpenCBus/Chapter%2010%20-%20C-Bus%20Ventilation%20Application.pdf
+    @Nested
+    class VentilationApplicationTest{
+        // TODO: no tests described here but it should work by adjusting the values from Lightning...
+    }
 }
diff --git a/protocols/c-bus/src/main/resources/protocols/cbus/c-bus.mspec b/protocols/c-bus/src/main/resources/protocols/cbus/c-bus.mspec
@@ -1314,7 +1314,8 @@
             [simple LightingData lightingData]
         ]
         ['VENTILATION'                          *Ventilation
-            [validation '1==2' "VENTILATION Not yet implemented"] // TODO: implement me
+            // Note: the documentation states that the data for ventilation uses LightingData
+            [simple LightingData ventilationData]
         ]
         ['IRRIGATION_CONTROL'                   *IrrigationControl
             [validation '1==2' "IRRIGATION_CONTROL Not yet implemented"] // TODO: implement me