Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning cleanup #1

Merged
merged 8 commits into from
Jan 8, 2018
Merged

Warning cleanup #1

merged 8 commits into from
Jan 8, 2018

Conversation

dlaboss
Copy link
Member

@dlaboss dlaboss commented Jan 8, 2018

Cleanup a number of warnings reported by Eclipse.
There are still 50+ warnings related to raw types, casts, type safety as well as unused field/local-variables.

Please comment if you have concerns with any of these changes.

@justinmclean justinmclean merged commit 531766c into apache:master Jan 8, 2018
@justinmclean
Copy link
Member

IMO no need for a PR for still like this feel free to commit yourself.

@dlaboss
Copy link
Member Author

dlaboss commented Jan 9, 2018

Hi Justin, I was expecting to merge it myself, but thanks :-)
Isn't is just better to consistently work in the github fork/feature-branch/PR flow so as to reinforce its use? It just makes it easier for folks to identify/review/comment on changes. And when build/test checks are integrated into the PR flow their "passing" is made readily apparent in the PR.

@chrisdutz
Copy link
Contributor

Well we should get the Travis support working first or you will be working without CI ... I've already setup the travis file thing, but still have to have Infra enable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants