Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ab eth station address parameter #102

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Ab eth station address parameter #102

merged 1 commit into from
Dec 2, 2019

Conversation

vemmert
Copy link
Contributor

@vemmert vemmert commented Dec 2, 2019

Until now the station parameter, which is part of the DF1 block within the AB-ETH frame was defaulted to 8. It is now part of the connection string.

@vemmert vemmert marked this pull request as ready for review December 2, 2019 11:47
chrisdutz
chrisdutz approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@chrisdutz chrisdutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulianFeinauer
Copy link
Contributor

@vemmert looks good to me too : )
It would be nice to squash those commints into one to have fewer noise in the history (git rebase -i origin/develop). Is that okay for you?

@vemmert vemmert force-pushed the ab-eth-station-address-parameter branch from 77da76d to 37305cf Compare December 2, 2019 13:50
@vemmert
Copy link
Contributor Author

vemmert commented Dec 2, 2019

It would be nice to squash those commints into one to have fewer noise in the history (git rebase -i origin/develop). Is that okay for you?

Done.

@JulianFeinauer
Copy link
Contributor

thanks!

@JulianFeinauer JulianFeinauer merged commit 7d73e38 into apache:develop Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdutz chrisdutz chrisdutz approved these changes

@JulianFeinauer JulianFeinauer JulianFeinauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vemmert @JulianFeinauer @chrisdutz