Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic example of connecting an S7 device to Azure IoT Hub #11

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

DerDackel
Copy link

Just a minimal PoC to deliver some bytes read from an S7 controller to Azure IoT Hub via MQTT

@chrisdutz
Copy link
Contributor

Hi, thanks for this pull request.
However could I ask you to rather create a new example in the example section containing only that code?

@DerDackel
Copy link
Author

Whatever do you mean? ;)

Realized my mistake immediately after submitting this PR and re-pushed the whole branch.

@asfgit asfgit merged commit 5202c9d into apache:master Aug 13, 2018
@chrisdutz
Copy link
Contributor

Well I had to do some maven magic as there seem to have been contradicting maven versions in the transitive deps, added Apache headers to all files and fixed a little problem in the program (The "OUTPUTS/0" Address was hard-coded ... replaced that with a 3rd argument.

Thanks for this first contribution to Apache PLC4X.

We would be very happy to see more commits like this in the future :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants