Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plc4x-server): Build a standalone jar too #1167

Merged
merged 1 commit into from Oct 21, 2023

Conversation

takraj
Copy link
Contributor

@takraj takraj commented Oct 19, 2023

Build a fat jar that contains all the dependencies, so user can set up a plc4x proxy server much easier.

$ java -jar plc4j-plc4x-server-0.12.0-SNAPSHOT-uber-jar.jar
11:50:07.822 [main] DEBUG io.netty.util.internal.logging.InternalLoggerFactory -- Using SLF4J as the default logging framework
11:50:07.826 [main] DEBUG io.netty.channel.MultithreadEventLoopGroup -- -Dio.netty.eventLoopThreads: 24
11:50:07.833 [main] DEBUG io.netty.util.concurrent.GlobalEventExecutor -- -Dio.netty.globalEventExecutor.quietPeriodSeconds: 1
11:50:07.839 [main] DEBUG io.netty.util.internal.InternalThreadLocalMap -- -Dio.netty.threadLocalMap.stringBuilder.initialSize: 1024
11:50:07.839 [main] DEBUG io.netty.util.internal.InternalThreadLocalMap -- -Dio.netty.threadLocalMap.stringBuilder.maxSize: 4096
...

Build a fat jar that contains all the dependencies, so user can
set up a plc4x proxy server much easier.

```
$ java -jar plc4j-plc4x-server-0.12.0-SNAPSHOT-uber-jar.jar
11:50:07.822 [main] DEBUG io.netty.util.internal.logging.InternalLoggerFactory -- Using SLF4J as the default logging framework
11:50:07.826 [main] DEBUG io.netty.channel.MultithreadEventLoopGroup -- -Dio.netty.eventLoopThreads: 24
11:50:07.833 [main] DEBUG io.netty.util.concurrent.GlobalEventExecutor -- -Dio.netty.globalEventExecutor.quietPeriodSeconds: 1
11:50:07.839 [main] DEBUG io.netty.util.internal.InternalThreadLocalMap -- -Dio.netty.threadLocalMap.stringBuilder.initialSize: 1024
11:50:07.839 [main] DEBUG io.netty.util.internal.InternalThreadLocalMap -- -Dio.netty.threadLocalMap.stringBuilder.maxSize: 4096
...
```
@sruehl sruehl requested a review from chrisdutz October 20, 2023 07:49
@sruehl
Copy link
Contributor

sruehl commented Oct 20, 2023

LGTM, @chrisdutz any objections?

@chrisdutz
Copy link
Contributor

No objections to building fat jars, however I would not want to use these as maven dependencies in the project.

Also do I think that we don't need to explicitly attach the uber-jar as I think I remember the shade plugin does that for us.

@chrisdutz
Copy link
Contributor

Just noticed that you're only talking about the server ... sure ... that's not used from anywhere else.

@chrisdutz chrisdutz merged commit 18883b1 into apache:develop Oct 21, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants