Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/s7h #1214

Merged
merged 5 commits into from
Nov 18, 2023
Merged

Issue/s7h #1214

merged 5 commits into from
Nov 18, 2023

Conversation

glcj
Copy link
Contributor

@glcj glcj commented Nov 18, 2023

  1. Fixes problems with the pipes created by the SPI and the driver architecture.
  2. URL handling is corrected.
  3. Reading example S71200, S7400H and Cyclic Subscription for S7300 and S7400 are improved.

@glcj glcj merged commit 5f6c232 into develop Nov 18, 2023
39 of 41 checks passed
@glcj glcj deleted the issue/s7h branch November 18, 2023 03:48
chrisdutz
chrisdutz reviewed Nov 18, 2023
View reviewed changes
Copy link
Contributor

@chrisdutz chrisdutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you moved the code generation or of the code generation profile. I please don't immediately merge this, I think it needs some cleaning up.

@chrisdutz
Copy link
Contributor

Ok... Just saw that it's already merged 😔 guess I'll be doing some cleaning up today then.

@korni128 korni128 mentioned this pull request Jun 4, 2024
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdutz chrisdutz chrisdutz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glcj @chrisdutz @ceos01