PLC4X-197 do not stop the global timer, remove and cancel the Timeouts instead #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rat exception for cmake-* directories'
|
I am open to suggestions on how to write a test for this |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rat exception for cmake-* directories' as well.
SingleItemToSingleRequestProtocol uses the global DefaultNettyPlcConnection timer object, which is a static singleton shared between all instances.
It was calling
stop()on the timer, which cancels all the outstanding tasks in the timer when the channel when inactive. This has the effect of killing all the other connections.This pr changes SingleItemToSingleRequestProtocol to instead, cancel all it's outstanding Timeouts and not touch the timer.
This change is