add modbus support BIG_ENDIAN_WORD_SWAP and LITTLE_ENDIAN_WORD_SWAP #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottlukas
added
Modbus
|
Adding the missing header after merging. |
|
Ok ... so it turns out that this PR had huge side-effects on protocols such as ADS, as it didn't consider uint 32 or not full short values. I had to revert the changes ... I moved the ByteOrder Helper into the modbus protocol and created a new type: ModbusByteOrder. I don't think this Word-Swap functionality is needed anywhere else than Modbus, so I would like to keep the changes there. |
chrisdutz
added a commit
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modbus support BIG_ENDIAN_WORD_SWAP
modbus support LITTLE_ENDIAN_WORD_SWAP