Setting third parameter to emptyCollection in static of methods call to SymbolicAdsTag #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initializing arrayInfo variable with immutable empty list in static of method.
…cAdsTag Update SymbolicAdsTag.java static of method
|
Maybe it is more reasonable to return a immutable empty collection in getArrayInfo method if the field is null... (If someone set it to null it is unlikely that there will be more than one value, right?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in subscription where the SymbolicAdsTag gets casted to DefaultSubscriptionTag.
It was possible that the arrayInfo field wasn't initialized which lead to a NullpointerException.