Fix ToAnsi method : bufferoverflow #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. |
|
Hi Johanna, sorry for me picking this up so late ... I just had a look ... your code changes generally look good, and I'm not going to insist on tests as in that case I would have to reject most of my stuff to ;-) Does the driver work with your changes? Are you able to read with multiple "." in them? I'm asking this stupid questions as I don't know the protocol and want to understand if this just makes the Execption go away. Chris |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToAnsi metod in EipProtocolLogic throws Bufferoverflow exception for tags that have more than one '.' in it.
Fixed by increased allocated data in Buffer.