PLC4X-244 Support for variable length padding fields. #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Padding expression must now evaluate to an integer specifying how many times 'padding' field needs to be read or written to the buffer.
|
I will probably need to add something to the size-calculation in C too, but I'll take care of this. Perhaps also change the name of the varialbe from "needsPadding" to "numPading" or similar ... "needs" sounds binary to me. |
…icate it's no longer a boolean.
|
Just saw that due to the nature of C ... you found all the places that needed adjusting ... thank you very much :-) |
chrisdutz
approved these changes
Sep 1, 2020
|
Good spot on naming, I did a blind change trying to keep it close to initial names. Anyhow, thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Padding expression must now evaluate to an integer specifying how many times 'padding' field needs to be read or written to the buffer.
S7 parser tests are fine with this change as well as my experiments with socketcan payloads.