Feature/write extended registers #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a cast to the PLCValue parameter so that we are able to use non standard methods to decode request
Sample Modbus.mspec change to be able to specify the datatype when parsing the PLCValue.
This allows IEC61131 datatypes INT (r/w) and UINT (Write only) to be used to convert Modbus registers.
This is to avoid needlessly casting it.
Outstanding items:- There is a readBigInteger method which isn't implemented yet. Exception raised when reading ULINT. Documentation Discuss if this should be included in other protocols at this point.
Allow IEC 61131 values to be use with the Modbus protocol
This was done so that a PLCList can be created from data from the PLC of the IEC types. Otherwise Java PlcValue would be used.
…e/ModbusDataType
- Refactored the existing Java type based PlcValues to a more generic IEC 61131-3 based type system. - Got everything working, all tests to pass etc and did some testing of S7 and Modbus reading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for writing extended registers.