PLC4X-265 Support for hex mapping of byte/byte[] values in XML test #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm ok ... so you extended the API model classes with explicit serialization code ... would it be possible to have this sort of outside of the API classes? If included in the API, I would prefer the default Java XML DOM instead of Dom4j ... I Like the DOM4J api more than the default, but I wouldn't want to force that on the users. |
Which place do you mean - plc field implementation or test framework? |
chrisdutz
reviewed
Dec 30, 2020
plc4j/drivers/eip/src/main/java/org/apache/plc4x/java/eip/readwrite/field/EipField.java
Show resolved
Hide resolved
splatch
force-pushed
the
feature/xml-raw-values
branch
from
2b4b335
to
3630729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are small updates in EIP stuff which shouldn't break anything.