Add enum's for opc ua driver in mspec #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for connection string optional fields tcp and params.
| @@ -68,12 +69,14 @@ public static OpcuaField of(String address) { | |||
| String identifier = matcher.group("identifier"); | |||
|
|
|||
| String identifierTypeString = matcher.group("identifierType"); | |||
| OpcuaIdentifierType identifierType = OpcuaIdentifierType.fromString(identifierTypeString); | |||
| OpcuaIdentifierType identifierType = OpcuaIdentifierType.enumForValue(identifierTypeString); | |||
There was a problem hiding this comment.
What happens if it is an invalid value?
There was a problem hiding this comment.
A null pointer exception is eventually raised, might be worth adding a contains key to the enum template as it looks like it is a concern with all of the Field classes.
Add check for datatype enum values in OpcField. Add tests for optional connection string parameters. Add additional tests for datatypes in address string.
ottobackwards
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for connection string optional fields tcp and params.