Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLC4Py maven integration #220

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Conversation

vemmert
Copy link
Contributor

@vemmert vemmert commented Jan 8, 2021

No description provided.

@vemmert vemmert marked this pull request as draft January 8, 2021 14:46
@vemmert vemmert marked this pull request as ready for review January 8, 2021 14:47
@ottobackwards
Copy link
Contributor

we are using poetry, you don't need the setup tools

poetry install && poetry build

@ottobackwards
Copy link
Contributor

As per our discussion, we need to do more to make this work in the scenarios:
new user not using mvn
new user using mvn

subsequent mvn builds

with regards to virtual env, setup, dependency installs.

We can land this, i'll create a follow on for making that stuff work

Copy link
Contributor

@ottobackwards ottobackwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow on required

@ottlukas ottlukas merged commit 5149731 into apache:feature/plc4py Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants