PLC4X-311 Handling of compact answers for ADS read requests. #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll ask my contacts at Beckhoff about some information for this issue. |
|
I have not tested it yet, however I located integration tests where we have ADS payloads where I could fit it.
I planned to take care of it this week, but got stuck in other things. Feel free to take care of it, otherwise I will sort it out next week.
|
|
Given comments on PLC4X-311 issue in JIRA I consider this fix as unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look on fix. I tested it with TC2 and it works fine. I am not quite sure if such serious mspec modification is justified. I'd opt for optional fields, however I am not sure if we can have an
optional implicit.