fix communication with LOGO 0AB7 and ISOonTCP tsap configuration #308
Conversation
add local-tsap and remote-tsap to s7 options because this values can not generated, they are specific to each ISO connection like port numbers
|
Hi Sven (hope that's right) Thank you for this PR ... I had already heard that there were issues with the LOGO devices, but didn't have the time to investigate any further. I'll test your changes against my LOGO as well as against my S7 devices. If the changes don't have any negative effect on the S7, I think it's safe to merge this PR. Thank you for contributing :) Chris |
|
Shall we move forward on this one? I guess @chrisdutz is only one having logo to test these changes, however if it works for author I don't see why it wouldn't work for others. :) |
|
I agree, I just got my logo beim the basement yesterday... Currently looking for a power supply. But I think it's OK to merge. Chris |
|
Hi Svenk ... sorry so much for the long time noone did anything here ... had a bit of crazy times ... will try to merge your changes right away. |
LOGO7 needs special attention when building the COTP request. The parameters must be in c1, c2, c0 order.
For ISOonTCP communications it is necessary that local and remote tsap can be specified. They act kinda like port numbers.