Extend field with type information #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The PlcField interface has a (default) method to return the expected java type (to know this upfront) * The PlcConnection interface has a new "parse()" method which allows to explicitly create a Field instance for a given type. * Integration of java-type into TriggeredScraper * Tested and added a TriggeredScraper for Modbus
asfgit
force-pushed
the
extend-Field-with-type-information
branch
from
39c9b47
to
11d2b20
Compare
|
Hey ... i made a few changes so that Scraper isn't dependent on S7 and added a scraper yml and test for Modbus that has been working fine ... so i think that could be mergt ... what do the others think?! |
|
If it works, … merge it 😉 (my opinion)
Chris
Von: timbo2k <notifications@github.com>
Antworten an: apache/incubator-plc4x <reply@reply.github.com>
Datum: Sonntag, 10. März 2019 um 16:29
An: apache/incubator-plc4x <incubator-plc4x@noreply.github.com>
Cc: Christofer Dutz <christofer.dutz@c-ware.de>, Review requested <review_requested@noreply.github.com>
Betreff: Re: [apache/incubator-plc4x] Extend field with type information (#47)
Hey ... i made a few changes so that Scraper isn't dependent on S7 and added a scraper yml and test for Modbus that has been working fine ... so i think that could be mergt ... what do the others think?!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#47 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAnvYU4REKkNb4vDrbRGaCJOQmiYCcEYks5vVSTogaJpZM4bixxc>.
|
|
+1 (I even heard the original pr author is a very good looking guy...).
Go merge it
Julian
Von meinem Mobiltelefon gesendet
…-------- Ursprüngliche Nachricht --------
Betreff: Re: [apache/incubator-plc4x] Extend field with type information (#47)
Von: Christofer Dutz
An: apache/incubator-plc4x
Cc: Julian Feinauer ,Author
If it works, … merge it 😉 (my opinion)
Chris
Von: timbo2k <notifications@github.com>
Antworten an: apache/incubator-plc4x <reply@reply.github.com>
Datum: Sonntag, 10. März 2019 um 16:29
An: apache/incubator-plc4x <incubator-plc4x@noreply.github.com>
Cc: Christofer Dutz <christofer.dutz@c-ware.de>, Review requested <review_requested@noreply.github.com>
Betreff: Re: [apache/incubator-plc4x] Extend field with type information (#47)
Hey ... i made a few changes so that Scraper isn't dependent on S7 and added a scraper yml and test for Modbus that has been working fine ... so i think that could be mergt ... what do the others think?!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#47 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAnvYU4REKkNb4vDrbRGaCJOQmiYCcEYks5vVSTogaJpZM4bixxc>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#47 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AQToCjpLLm1hnpXZ3XYOLiN39BPYvD2Gks5vVUKNgaJpZM4bixxc>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heyho, this PR refers to the mail exchange with the driver specificality of the (new) scraper (PR #46 ).
Please check if this change is acceptable for you (I used Javas (bad) default feature to keep everything compatible).
@timbo2k could you check if this fixes all s7 depenedncies of your scraper?