Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend field with type information #47

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

JulianFeinauer
Copy link
Contributor

Heyho, this PR refers to the mail exchange with the driver specificality of the (new) scraper (PR #46 ).
Please check if this change is acceptable for you (I used Javas (bad) default feature to keep everything compatible).

@timbo2k could you check if this fixes all s7 depenedncies of your scraper?

* The PlcField interface has a (default) method to return the expected java type (to know this upfront)
* The PlcConnection interface has a new "parse()" method which allows to explicitly create a Field instance for a given type.
* Integration of java-type into TriggeredScraper
* Tested and added a TriggeredScraper for Modbus
@asfgit asfgit force-pushed the extend-Field-with-type-information branch from 39c9b47 to 11d2b20 Compare March 10, 2019 15:18
@timbo2k
Copy link
Contributor

timbo2k commented Mar 10, 2019

Hey ... i made a few changes so that Scraper isn't dependent on S7 and added a scraper yml and test for Modbus that has been working fine ... so i think that could be mergt ... what do the others think?!

@chrisdutz
Copy link
Contributor

chrisdutz commented Mar 10, 2019 via email

@JulianFeinauer
Copy link
Contributor Author

JulianFeinauer commented Mar 10, 2019 via email

@timbo2k timbo2k merged commit 22d573e into develop Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants