Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLC4X-129 Improve version detection macro. #71

Merged
merged 1 commit into from
May 27, 2019

Conversation

splatch
Copy link
Contributor

@splatch splatch commented May 27, 2019

Attached PR contains changed regexp. Additionally same regexp is used for all programs as it was copy/pasted all over the place.

@JulianFeinauer
Copy link
Contributor

🎉 Congratz to your first MERGED PR Lukasz 👍

@JulianFeinauer JulianFeinauer merged commit 8d9cae7 into apache:develop May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants