fix bug in opc ua driver response handling when fields are not found #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me ... and I did see it fail before and work with the change ;-) |
nalim2
reviewed
Aug 1, 2019
| @@ -346,7 +346,7 @@ public void unregister(PlcConsumerRegistration registration) { | |||
| for(int counter = 0; counter < readValueIds.size(); counter++){ | |||
| PlcResponseCode resultCode = PlcResponseCode.OK; | |||
| BaseDefaultFieldItem stringItem = null; | |||
| if(readValues == null || readValues.size() <= counter || readValues.get(counter).getStatusCode() != StatusCode.GOOD){ | |||
| if(readValues == null || counter > readValues.size() || !readValues.get(counter).getStatusCode().isGood()){ | |||
There was a problem hiding this comment.
Correct but it has to be counter >= readValues.size() or?
So that we do not get a out of bounds if counter == .size()
There was a problem hiding this comment.
Actually I think you are right as if it's equal to size it must produce an array index out of bounds exception. Stefan, could you please re evaluate that?
There was a problem hiding this comment.
you are correct, will fix that.. :)
nalim2
added a commit
that referenced
this pull request
Dec 18, 2019
PLC4X-164: Fix wrong NOT FOUND exception in OPC-UA driver Correct fix for similliar issue like #75. This will lead into a code refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug within the check for returned fields in the opc ua driver connection response, where the status code was wrongly compared.
Updates the milo dependencies.