New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/nifi integration address text #755
Feature/nifi integration address text #755
Conversation
* Added description to acceptable values in Address Access Strategy
…egration-address-text
…egration-address-text
Thanks for the contribution!
In order for this PR to land, it would have to address the caching issue. Having json addresses the "don't invent a custom addressing delimiter" issue. We would just have to live with how poor writing complicated json in that UI would be ( or doing it external and cut and pasting it in) |
* Added an Avro RecordSchema cache with FIFO replacement policy
…egration-address-text
@ottobackwards regarding the cache: I have done some tests and seems to speed up ut to 10x the processors. At the moment each processor has its cache and a new property: Schema Cache Size with default value 1. Waiting for feedback |
...-plc4x-processors/src/main/java/org/apache/plc4x/nifi/record/Plc4xReadResponseRecordSet.java
Show resolved
Hide resolved
...-plc4x-processors/src/main/java/org/apache/plc4x/nifi/record/Plc4xReadResponseRecordSet.java
Show resolved
Hide resolved
...pache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/record/SchemaCache.java
Show resolved
Hide resolved
* Test addSchema * Test first in first out schema override in addSchema
* Change lastSchemaPosition to nextSchemaPosition * Refactor setCacheSize to restartCache * Change validator for cache size to positive integer (>0)
…egration-address-text
Thank you for your feedback @ottobackwards! |
This looks good. If you are ready, I will let you move it from Draft to ready for review, then I'll finish up |
Just going through and removing jackson being pinned at version 2.14.1, this will result in it being bumped to 2.14.2. This was causing an issue with the build. Let me know if there was a specific reason this was being held back. |
Must be a left over from testing. There is not any reason, sorry for the inconvenience |
Proposal to add a property in NiFi-integration processors to allow users to choose address definition strategy and add support for Expression Language in addresses definition.
Issues related:
Actual behavior:
Addresses are specified one by one as dynamic properties in the processor and stored in a map when
onScheduled
method is triggered.Expression Language is not supported.
Proposed behavior:
Let user decide between 2 strategies to obtain addresses in the processor:
An address map created every time when
onTrigger
method is called.