Feature/nifi integration sink record processor and minor fixes #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add unit test * Add response code check for Plc4xSinkProcessor
* Added Common properties entry to readme * Added Plc4xSinkRecordProcessor entry to readme
…egration-sink-record-processor
…egration-sink-record-processor
…egration-sink-record-processor
…egration-sink-record-processor
…egration-sink-record-processor
…egration-sink-record-processor
* Added comment to commented lines in common tests
…egration-sink-record-processor
…egration-sink-record-processor
* Add a check if debug logger is enabled * Update tags of all processors * Check if record sink response is not null * Simplify record reader creation
…egration-sink-record-processor
...pache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/Plc4xSinkProcessor.java
Outdated
Show resolved
Hide resolved
...nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/Plc4xSinkRecordProcessor.java
Show resolved
Hide resolved
* Added exists chech to flowfile attribute in Plc4xSinkProcessor
|
Thanks for the update. I have no more requests, if you are set can you make this Ready for review and move out of draft status? |
|
Thanks for the PR @QuanticPony |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the NiFi integration has attribute based sink and source and a record based source. This PR attempts to bring a record based sink processor and some minor fixes to the nifi integration.
Changes:
Waiting for feedback