Ab eth data types and doc #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vemmert
commented
Oct 2, 2019
vemmert
commented
- Added WORD (2 bytes) and DWORD (4 bytes) to the AB-ETH driver
- Added a short documentation for potential AB-ETH users to the website
- Short doc for AB-ETH PLC users
|
Excellent @vemmert ... I will try to review this ASAP. |
chrisdutz
requested changes
Oct 10, 2019
pom.xml
Outdated
| <requires> | ||
| <require>asciidoctor-diagram</require> | ||
| </requires> | ||
| </asciidoc> |
There was a problem hiding this comment.
Why did you remove this?
There was a problem hiding this comment.
Just wanted to make sure the reviewers aren't asleep.
(No idea and it wasn't on purpose -__- )
There was a problem hiding this comment.
The thing is, if you don't add it back again, I will not merge it ... so please update your PR and then I can merge it.
chrisdutz
approved these changes
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.