Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #801 #888

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Closes #801 #888

merged 2 commits into from
Sep 25, 2023

Conversation

DmitriiMukhin
Copy link
Contributor

@DmitriiMukhin DmitriiMukhin commented Apr 5, 2023

Fixing issue with org.apache.plc4x.java.spi.connection.DefaultNettyPlcConnection - java.lang.OutOfMemoryError: unable to create native thread.

@DmitriiMukhin DmitriiMukhin changed the title Fixing https://github.com/apache/plc4x/issues/801 Closes #801 Apr 5, 2023
@sruehl sruehl requested review from splatch and chrisdutz April 6, 2023 10:31
@chrisdutz
Copy link
Contributor

Could you please explain a bit what the problem was?

@DmitriiMukhin
Copy link
Contributor Author

Could you please explain a bit what the problem was?

Issue

@chrisdutz chrisdutz merged commit e4b64a1 into apache:develop Sep 25, 2023
@chrisdutz
Copy link
Contributor

I merged the issue after I saw it didn't cause any harm in the testsuite ... however I have no idea why the changes should possibly fix the issue. I just want you folks to be unblocked. I'll try to read into the changes and try to understand.
In the future it would be cool, if the code comments would describe the why a bit more ... "fixes ABC" won't help anyone having a look at the code in 2 years without looing up the initial issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants