-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/resolve split package osgi #89
Feature/resolve split package osgi #89
Conversation
Its not intended to be merged, yet its. First, we should check it in-depth. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Julian,
I think it would have been better to rename things from:
org.apache.plc4x.java.base.connection
To:
org.apache.plc4x.java.connection.tcp
org.apache.plc4x.java.connection.serial
org.apache.plc4x.java.connection.mock
...
as it sort of gets more and more concrete further down the package ...
What do you think? cause the way you currently have it, it's sort of an empty "connection" package for every type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Julian,
I think it would have been better to rename things from:
org.apache.plc4x.java.base.connection
To:
org.apache.plc4x.java.connection.tcp
org.apache.plc4x.java.connection.serial
org.apache.plc4x.java.connection.mock
...
as it sort of gets more and more concrete further down the package ...
What do you think? cause the way you currently have it, it's sort of an empty "connection" package for every type.
And I agree with you @chrisdutz with the naming. I just wanted to make the smalles changes possible which was base -> xxx. |
How about throwing in a readme in the karaf features area? |
We already had "plc4j/integrations/apache-karaf" modules and there we were using the goal "features-generate-descriptor" which generates the "feature.xml" ... the way you're currently doing it would require to manually maintain a second resource with dependency information. |
Ok ... I compared the feature.xml you added manually, that's identical to the one generated by the plugin, except that it has one additional entry: scr |
ac8b7e8
to
a14fe10
Compare
plc4j/karaf-features/karaf-itest/src/test/resources/etc/system.properties
Outdated
Show resolved
Hide resolved
- Split up one execution of two goals into two separate ones - Added a transformation that injects the "<feature>scr</feature>" into the gerated feature.xml
- Added a missing OPCUA feature - Added the OPCUA feature to the demo-server
- Cleaned up the maven config
95c37c0
to
ecc5def
Compare
This PR brings full OSGi support to PLC4X.
A bundle for the S7 driver is also added.