PLC4X-144 - When requesting invalid addresses, the DefaultS7MessagePr… #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocessor produces errors - The DefaultS7MessageProcessor didn't inspect the return code and tried to merge invalid fields, hereby causing array index errors ... by checking the status code this should be fixed
|
@chrisdutz I cannot judge on the exact changes, it looks "ok". Did you run some tests against a PLC of yours (Logo?)? Otherwise I would try to do this later today or tomorrow... |
|
The real thing was what I was able to reproduce the error and verify the fix against the real thing ... I wasn't able to reproduce it in the Unit-Test World however. |
|
I tested it against the S7-1200 ... the logo is very restrictive ... it seems it doesn't have any graceful error handling ... as soon as it reads something it doesn't like, it hangs up without saying goodbye. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to reproduce the error when talking to a real machine and pretty quickly found the problem. However I spent 1,5 hours trying to whip up a test to reproduce the error and failed to do so.