Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLC4X-144 - When requesting invalid addresses, the DefaultS7MessagePr… #91

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

chrisdutz
Copy link
Contributor

I was able to reproduce the error when talking to a real machine and pretty quickly found the problem. However I spent 1,5 hours trying to whip up a test to reproduce the error and failed to do so.

…ocessor produces errors

- The DefaultS7MessageProcessor didn't inspect the return code and tried to merge invalid fields, hereby causing array index errors ... by checking the status code this should be fixed
@JulianFeinauer
Copy link
Contributor

@chrisdutz I cannot judge on the exact changes, it looks "ok". Did you run some tests against a PLC of yours (Logo?)? Otherwise I would try to do this later today or tomorrow...

@chrisdutz
Copy link
Contributor Author

The real thing was what I was able to reproduce the error and verify the fix against the real thing ... I wasn't able to reproduce it in the Unit-Test World however.

@chrisdutz
Copy link
Contributor Author

I tested it against the S7-1200 ... the logo is very restrictive ... it seems it doesn't have any graceful error handling ... as soon as it reads something it doesn't like, it hangs up without saying goodbye.

@chrisdutz chrisdutz merged commit aefcd26 into develop Oct 21, 2019
@asfgit asfgit deleted the feature/PLC4X-144 branch October 23, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants