Add support of PlcDINT for BigInteger in PlcValueHandler #962
Conversation
PatrykGala
changed the title
Enable OpcuaPlcDriverTest.
There was a problem hiding this comment.
Please don't just disable tests without opening a new issue for it ... this way we have already disabled very many tests, tests we don't know about or forget.
There was a problem hiding this comment.
I am enabling in this PR, the test was disabled in 0af938f
| @@ -83,6 +83,9 @@ public static PlcValue of(Object[] values) { | |||
| if (value instanceof Long) { | |||
| return PlcLINT.of(value); | |||
| } | |||
| if (value instanceof BigInteger) { | |||
| return PlcDINT.of(value); | |||
There was a problem hiding this comment.
Woudln't a LINT be the better match, as a BigInteger could actually be even bigger than the DINT value space?
There was a problem hiding this comment.
Yes, PlcLINT is better choose. I've pushed the change.
| @@ -195,7 +195,7 @@ public CompletableFuture<PlcReadResponse> read(PlcReadRequest readRequest) { | |||
| future.complete(new DefaultPlcReadResponse(request, status)); | |||
| return; | |||
| } | |||
| } catch (ParseException e) { | |||
| } catch (Exception e) { | |||
There was a problem hiding this comment.
What was the reasoning behind this?
There was a problem hiding this comment.
The uncaught PlcUnsupportedDataTypeException thrown by PlcValueHandler prevents the CompletableFuture from completing, causing the thread to hang on CompletableFuture.get(). By making this change, the test will now complete with an Exception instead of hanging indefinitely.
|
@chrisdutz if you're ok with changes (PlcLINT is in place) I'd proceed with merging. |
|
Please enable the test first |
As far I can see this PR enables test which was disabled. |
|
Indeed it does... So ignore my mumbling 😁 |
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaProtocolLogic.java
Outdated
Show resolved
Hide resolved
…protocol/OpcuaProtocolLogic.java
PlcUnsupportedDataTypeExceptionfromPlcValueHandlercaused the CompletableFuture not to complete, theOpcuaPlcDriverTesthangs onCompletableFuture.get()