- Moved the plc4cpp, plc4net and plc4py into the sandbox #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrisdutz
commented
Oct 31, 2019
chrisdutz
commented
- Removed the "with-java" profile
- Adjusted the documentation
- Added documentation to the latest mspec changes
- Removed the "with-java" profile - Adjusted the documentation - Added documentation to the latest mspec changes
-- Need to have OpenSSL installed -- Avoid installing to locations with spaces in the path
JulianFeinauer
requested changes
Nov 2, 2019
There was a problem hiding this comment.
@chrisdutz I just checked it out and mvn clean install works nicely, well done!
But I have issues whenever the with-dotnet Profile is enabled on my Mac. Is this something which is bad or is this "okay"?
Furthermore I get the Exception
Scanning dependencies of target thriftnb
[ 83%] Building CXX object lib/cpp/CMakeFiles/thriftnb.dir/src/thrift/server/TNonblockingServer.cpp.o
[ 84%] Building CXX object lib/cpp/CMakeFiles/thriftnb.dir/src/thrift/transport/TNonblockingServerSocket.cpp.o
[ 85%] Building CXX object lib/cpp/CMakeFiles/thriftnb.dir/src/thrift/transport/TNonblockingSSLServerSocket.cpp.o
In file included from /Users/julian/Develop/incubator-plc4x/tools/thrift/target/thrift-0.13.0/lib/cpp/src/thrift/transport/TNonblockingSSLServerSocket.cpp:21:
/Users/julian/Develop/incubator-plc4x/tools/thrift/target/thrift-0.13.0/lib/cpp/src/thrift/transport/TSSLSocket.h:26:10: fatal error: 'openssl/ssl.h' file not found
#include <openssl/ssl.h>
^~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [lib/cpp/CMakeFiles/thriftnb.dir/src/thrift/transport/TNonblockingSSLServerSocket.cpp.o] Error 1
make[1]: *** [lib/cpp/CMakeFiles/thriftnb.dir/all] Error 2
make: *** [all] Error 2
when running mvn install -Pskip-prerequisite-check,development,with-sandbox,with-cpp,with-boost,with-python,with-proxies,with-logstash -DskipTests on my macOS.
JulianFeinauer
approved these changes
Nov 3, 2019
|
@chrisdutz just checked everything and I like it. So I would merge it, if nobody else vetoes? |
JulianFeinauer
deleted the
feature/moving-unfinished-things-to-the-sandbox
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.