trimming sheetnames > 31 chars #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
reviewed
Oct 31, 2021
poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java
Outdated
Show resolved
Hide resolved
centic9
reviewed
Nov 2, 2021
poi/src/test/java/org/apache/poi/hssf/usermodel/TestHSSFWorkbook.java
Outdated
Show resolved
Hide resolved
Warn about trimmed sheet names Throw exception when trimmed sheetname collides with existing sheet Implement sheetname trimming for HSSFWorkbook Add use case tests
manticore-projects
force-pushed
the
trunk
branch
from
b5048c1
to
654f184
Compare
|
Applied most of the changes, however throwing an Exception was not necessary as both HSSF and XSSF already validate for existing sheetnames with taking the max-length into account properly. |
|
Awesome! Thank you for looking into this and giving feedback. |
snsinahub
pushed a commit
to snsinahub-org/poi
that referenced
this pull request
Feb 28, 2023
Define Constant MAX_SENSITIVE_SHEET_NAME_LEN = 31 Warn about trimmed sheet names Implement sheetname trimming for HSSFWorkbook Add use case tests Closes apache#273 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1894817 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn about trimmed sheet names
Throw exception when trimmed sheetname collides with existing sheet
Implement sheetname trimming for HSSFWorkbook
Add use case tests