A fix for bug 66682. #485
Closed
A fix for bug 66682. #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… formula cells in binary excel files read with the event model are not handled. These cells are always yield empty values regardless of the evaluation of the formula. The simple fix is to use the same cell handler as for literal boolean values.
|
https://github.com/apache/poi/blob/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/binary/TestXSSFBSheetHyperlinkManager.java is a good test to copy. If you want to read in an xlsb file, copy it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem where values from boolean formula cells in binary excel files read with the event model are not handled. These cells are always yield empty values regardless of the evaluation of the formula. The simple fix is to use the same cell handler as for literal boolean values.
Tested and it works. I will add a test case if someone can give me some direction as to where it should go.